Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4751 feat create intervention policy misc adjustments #4902

Merged
merged 11 commits into from
Sep 25, 2024
Merged

4751 feat create intervention policy misc adjustments #4902

merged 11 commits into from
Sep 25, 2024

Conversation

asylves1
Copy link
Contributor

@asylves1 asylves1 commented Sep 24, 2024 •
edited by Tom-Szendrey
Loading

Description

image

Changes:

  • static interventions in a intervention will have the same value for timestep
  • each static intervention will have type which can be 'state/parameter'

Note Required:

DARPA-ASKEM/pyciemss-service#120

@asylves1 asylves1 linked an issue Sep 24, 2024 that may be closed by this pull request
[FEAT]: Create Intervention Policy - misc adjustments #4751
Closed
@asylves1 asylves1 marked this pull request as ready for review September 24, 2024 17:14
dvince2
dvince2 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@dvince2 dvince2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this is merged, we'll need to merge the pyciems service changes as well. @dgauldie we'll need the Interventions table on staging wiped too.

@dvince2 dvince2 mentioned this pull request Sep 24, 2024
Merged
Tom-Szendrey
Tom-Szendrey approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@Tom-Szendrey
Copy link
Contributor

We have a check for the first type, where we should be checking on each type:
image

@asylves1 asylves1 merged commit d2e0de9 into main Sep 25, 2024
8 checks passed
@asylves1 asylves1 deleted the 4751-feat-create-intervention-policy---misc-adjustments branch September 25, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 approved these changes

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@YohannParis YohannParis YohannParis approved these changes

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Create Intervention Policy - misc adjustments
4 participants
@asylves1 @Tom-Szendrey @YohannParis @dvince2