Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix simulate preset selection not triggering update #4921

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Sep 25, 2024

Summary

Change the order of variable updates for presets to take effect

Testing

  • Select a model with some parameter value variability (with lower/upper bound not equal).
  • Hook up model => model-config => simulate
  • Run "normal" simulation, then run "fast" simulation, it should be obvious the two runs are different as the former has significantly more samples than the latter.

Fixes: #4848

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwdchang mwdchang merged commit 1538ab2 into main Sep 25, 2024
4 checks passed
@mwdchang mwdchang deleted the fix-simulate-preset-options branch September 25, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Simulate in Normal preset not working
3 participants