Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 decode/encode to model description #4939

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Sep 26, 2024

This pull request includes several changes to the tera-model-description.vue component to enhance the handling of model descriptions by introducing base64 encoding and decoding. The key changes involve importing necessary utility functions, updating the editor content initialization, and modifying the watch function to ensure consistent encoding and decoding of the model descriptions.

Enhancements to model description handling:

Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, didn't test.

@dgauldie dgauldie merged commit cb1636d into main Sep 26, 2024
4 checks passed
@dgauldie dgauldie deleted the improve-model-asset-page branch September 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants