multiple input field open when selecting one #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asylves1
requested review from
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama and
blanchco
as code owners
asylves1
requested review from
kbirk and
mloppie
and removed request for
mwdchang,
jryu01 and
Tom-Szendrey
mwdchang
reviewed
Sep 27, 2024
...client/hmi-client/src/components/workflow/ops/document/tera-document-operation-drilldown.vue
Outdated
Show resolved
Hide resolved
mwdchang
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Can you please provide better PR description and testing instructions?
Your description "stops all input fields from opening when only the selected one should" seems like it has nothing to do with the source code change, which is about appending output-ports from what I can gather. Not sure if we are missing some commits, but better clarity would help the reviewers as well as tracking purposes.
YohannParis
reviewed
Sep 27, 2024
...client/hmi-client/src/components/workflow/ops/document/tera-document-operation-drilldown.vue
Outdated
Show resolved
Hide resolved
|
Removing code change from |
mwdchang
approved these changes
Sep 27, 2024
YohannParis
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue:
When a user clicks on an equation, all of the equations input field appear. This is due to the equations all sharing the same name:
Change:
Add the array index of the equation to the name parameter.
Testing:
Add 2 equations using the add equation field and select one of the equations. Only one input field should appear.
Resolves #(issue)