Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move gollm scripts into terarium #4968

Merged
merged 3 commits into from
Sep 30, 2024
Merged

move gollm scripts into terarium #4968

merged 3 commits into from
Sep 30, 2024

Conversation

dgauldie
Copy link
Collaborator

Description

  • Include a summary of the changes and the related issue.
  • Include relevant motivation and context.

Resolves #(issue)

@dgauldie dgauldie linked an issue Sep 27, 2024 that may be closed by this pull request
Move GoLLM scripts into terarium repo #4717
Closed
@dgauldie dgauldie requested review from kbirk and j2whiting September 27, 2024 18:14
YohannParis
YohannParis approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but packages/gollm/dev.sh does not work as expected.

@dgauldie
Copy link
Collaborator Author

LGTM, but packages/gollm/dev.sh does not work as expected.

what is wrong with it?

@YohannParis
Copy link
Member

Everything works for me!

@dgauldie dgauldie merged commit 15e658a into main Sep 30, 2024
8 checks passed
@dgauldie dgauldie deleted the 4717-move-gollm-scripts-into-terarium-repo branch September 30, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 approved these changes

@kbirk kbirk kbirk approved these changes

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@j2whiting j2whiting Awaiting requested review from j2whiting

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move GoLLM scripts into terarium repo
4 participants
@dgauldie @YohannParis @kbirk @dvince2