Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibrate timestamp field UI tweak #4992

Merged
merged 14 commits into from
Oct 1, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Sep 30, 2024

Description

  1. Timestamp column has its own state field.
  2. Timestamp column has its own section in the mapping (see screenshot below)
  3. On open node try to fill in the timestamp column if its not yet filled in. We will look for the first thing that starts with "time"

Warning:

This updates the state object for calibration so older calibration nodes will run into issues with their mappings.

Pics

image

With designs here: https://www.figma.com/design/SLO56PGmGq7kFQRFCeaPsY/Terarium---September-2024?node-id=235-584&node-type=canvas&t=3E0tQ1xlWHmsXuxp-0

@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review September 30, 2024 19:59
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tom-Szendrey Tom-Szendrey marked this pull request as draft October 1, 2024 17:42
@mwdchang
Copy link
Member

mwdchang commented Oct 1, 2024

Per discussion, we should figure out if we want to

  • allow potential invalid scenarios, and have mechanism to fix them after the fact, for example - having timestamp mapped multiple times doesn't really make sense. Or
  • prevent invalid scenarios from happening in the first place

@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review October 1, 2024 18:43
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mwdchang mwdchang merged commit 2fad48f into main Oct 1, 2024
4 checks passed
@mwdchang mwdchang deleted the TS/4904-calibrate-timestamp-field-ui-tweak branch October 1, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants