-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibrate timestamp field UI tweak #4992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S/4904-calibrate-timestamp-field-ui-tweak
Tom-Szendrey
requested review from
YohannParis,
mwdchang,
jryu01,
shawnyama,
blanchco and
asylves1
as code owners
September 30, 2024 19:59
…S/4904-calibrate-timestamp-field-ui-tweak
YohannParis
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shawnyama
reviewed
Oct 1, 2024
.../hmi-client/src/components/workflow/ops/calibrate-ciemss/tera-calibrate-ciemss-drilldown.vue
Outdated
Show resolved
Hide resolved
shawnyama
approved these changes
Oct 1, 2024
Per discussion, we should figure out if we want to
|
…S/4904-calibrate-timestamp-field-ui-tweak
mwdchang
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning:
This updates the state object for calibration so older calibration nodes will run into issues with their mappings.
Pics
With designs here: https://www.figma.com/design/SLO56PGmGq7kFQRFCeaPsY/Terarium---September-2024?node-id=235-584&node-type=canvas&t=3E0tQ1xlWHmsXuxp-0