-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename update output port #5000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannParis
requested review from
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
October 1, 2024 12:35
mwdchang
reviewed
Oct 1, 2024
mwdchang
reviewed
Oct 1, 2024
...ent/src/components/workflow/ops/model-from-equations/tera-model-from-equations-drilldown.vue
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
Oct 1, 2024
packages/client/hmi-client/src/components/workflow/ops/stratify-mira/tera-stratify-mira.vue
Outdated
Show resolved
Hide resolved
mwdchang
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test every operator changed here, looks okay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes focused on standardizing the event names in the
tera
components and improving code clarity. The changes primarily involve renaming theupdate-output-port
event toupdate-output
across various components and updating related function names accordingly.Event name standardization:
tera-code-asset-wrapper.vue
: Renamed the eventupdate-output-port
toupdate-output
and updated the corresponding emit call in theonApplyChanges
function.tera-intervention-policy-drilldown.vue
: Removed theupdate-output-port
event from thedefineEmits
call.tera-model-config-drilldown.vue
: Removed theupdate-output-port
event from thedefineEmits
call.ptera-model-edit.vue
: Renamed the eventupdate-output-port
toupdate-output
and updated the corresponding emit call in theupdateNode
function. [1] [2]era-model-from-equations-drilldown.vue
: Renamed the eventupdate-output-port
toupdate-output
and updated the corresponding emit call in theupdateNodeLabel
function. [1] [2]tera-stratify-mira.vue
: Renamed the eventupdate-output-port
toupdate-output
and updated the corresponding emit call in theupdateNodeOutput
function. [1] [2]Code clarity improvements:
tera-workflow.vue
: Updated the component bindings and event handlers to useupdate-output
instead ofupdate-output-port
. [1] [2]services/workflow.ts
: Updated the functionupdateOutputPort
toupdateOutput
and modified the implementation to use the new event name.