Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link equations to page #5018

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Link equations to page #5018

merged 6 commits into from
Oct 2, 2024

Conversation

asylves1
Copy link
Contributor

@asylves1 asylves1 commented Oct 2, 2024 •
edited
Loading

Description

Design change

  • when the user clicks on an equation the pdf's page will change to the page containing the equation.

Testing

  • Should see the current selected equation in the pdf viewer

image

Resolves #(issue)

@asylves1 asylves1 marked this pull request as ready for review October 2, 2024 18:12
@asylves1 asylves1 requested review from dgauldie and removed request for mwdchang, jryu01 and Tom-Szendrey October 2, 2024 18:12
@asylves1 asylves1 linked an issue Oct 2, 2024 that may be closed by this pull request
Link equations to page numbers #5017
Closed
YohannParis
YohannParis approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

blanchco
blanchco approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@blanchco blanchco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@asylves1 asylves1 merged commit 54b4778 into main Oct 2, 2024
4 checks passed
@asylves1 asylves1 deleted the ui-extraction-equation-style-changes branch October 2, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanchco blanchco blanchco approved these changes

@YohannParis YohannParis YohannParis approved these changes

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link equations to page numbers
3 participants
@asylves1 @YohannParis @blanchco