Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messaging around GoLLM tasks #5076 #5077

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

dvince2
Copy link
Collaborator

@dvince2 dvince2 commented Oct 7, 2024

Description

So it turns out that the events were already set up but we forgot to …remove the old task handler code. Removing that fixes the exceptions.

Resolves #5076

…remove the old task handler code. Removing that fixes the exceptions.
@dvince2 dvince2 linked an issue Oct 7, 2024 that may be closed by this pull request
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but do love it when a FIXME is fixed

@dvince2 dvince2 merged commit 0550c78 into main Oct 7, 2024
4 checks passed
@dvince2 dvince2 deleted the 5076-fix-messaging-around-gollm-tasks branch October 7, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix messaging around GoLLM tasks
3 participants