Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(funman): show model config in op and make config the output #5078

Merged
merged 19 commits into from
Oct 8, 2024
Merged

feat(funman): show model config in op and make config the output #5078

merged 19 commits into from
Oct 8, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 7, 2024 •
edited
Loading

Description

  • Show read only model config preview in drilldown preview
  • Output port has model config for use in simulation
  • Had to modify the way parameter distributions were being saved, funman always seems to return uniform distributions when there should be some constants.
Screen.Recording.2024-10-07.at.7.53.30.PM.mov

@shawnyama shawnyama changed the title feat: show model config in funman op and make config the output feat(funman): show model config in op and make config the output Oct 7, 2024
@shawnyama shawnyama linked an issue Oct 7, 2024 that may be closed by this pull request
[TASK]: funman operator displays validated config and outputs config #5069
Closed
@shawnyama shawnyama marked this pull request as ready for review October 8, 2024 00:08
@shawnyama shawnyama removed the request for review from mwdchang October 8, 2024 15:44
Tom-Szendrey
Tom-Szendrey approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good still testing

@YohannParis YohannParis merged commit bdc22e2 into main Oct 8, 2024
9 checks passed
@YohannParis YohannParis deleted the funman-shows-and-outputs-config branch October 8, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis left review comments

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@dvince2 dvince2 Awaiting requested review from dvince2 dvince2 is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

Assignees

@jryu01 jryu01

@Tom-Szendrey Tom-Szendrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: funman operator displays validated config and outputs config
4 participants
@shawnyama @YohannParis @Tom-Szendrey @jryu01