Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5038 bug intervention policies are not described well in simulate #5079

Conversation

YohannParis
Copy link
Member

Screenshot 2024-10-07 at 15 23 08

@dgauldie
Copy link
Collaborator

dgauldie commented Oct 8, 2024

@liunelson , doesn't it make more sense for the static strings to read "set parameter beta to 0.6 starting at day 15" instead of "set parameter beta to 0.6 at start time 15 day"

also... is "day" reasonable? I guess once we move to dates and timestamps, we can change...

@YohannParis
Copy link
Member Author

@liunelson , doesn't it make more sense for the static strings to read "set parameter beta to 0.6 starting at day 15" instead of "set parameter beta to 0.6 at start time 15 day"

also... is "day" reasonable? I guess once we move to dates and timestamps, we can change...

We use the words days, because that is what the user sees when creating those interventions, once we do the unit better, we can change that, but that is out of scope from this PR

@dgauldie
Copy link
Collaborator

dgauldie commented Oct 8, 2024

ok, I still think we should change the format of the string... keeping day

@YohannParis
Copy link
Member Author

ok, I still think we should change the format of the string... keeping day

Yes, that has been done already!

@liunelson
Copy link
Member

@liunelson , doesn't it make more sense for the static strings to read "set parameter beta to 0.6 starting at day 15" instead of "set parameter beta to 0.6 at start time 15 day"

also... is "day" reasonable? I guess once we move to dates and timestamps, we can change...

"day" is really just a placeholder or default value until the UI gets the time unit from the model AMR. With datetime, then the time unit is still relevant since it seems always helpful to see how much time has elapsed since the starting datetime.

@YohannParis YohannParis merged commit 79f8b03 into main Oct 9, 2024
4 checks passed
@YohannParis YohannParis deleted the 5038-bug-intervention-policies-are-not-described-well-in-simulate branch October 9, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Intervention policies are not described well in simulate.
3 participants