-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5038 bug intervention policies are not described well in simulate #5079
5038 bug intervention policies are not described well in simulate #5079
Conversation
…ibed-well-in-simulate
@liunelson , doesn't it make more sense for the static strings to read "set parameter beta to 0.6 starting at day 15" instead of "set parameter beta to 0.6 at start time 15 day" also... is "day" reasonable? I guess once we move to dates and timestamps, we can change... |
...ages/client/hmi-client/src/components/intervention-policy/tera-intervention-summary-card.vue
Show resolved
Hide resolved
We use the words days, because that is what the user sees when creating those interventions, once we do the unit better, we can change that, but that is out of scope from this PR |
ok, I still think we should change the format of the string... keeping day |
Yes, that has been done already! |
…ibed-well-in-simulate
"day" is really just a placeholder or default value until the UI gets the time unit from the model AMR. With datetime, then the time unit is still relevant since it seems always helpful to see how much time has elapsed since the starting datetime. |
…ibed-well-in-simulate
…ibed-well-in-simulate
tera-intervention-summary-card.vue
: Moving it to its own foldertera-intervention-policy-card.vue
: Improved the structure and styles, including the removal of unnecessary elements and the addition of a header section.tera-intervention-policy-drilldown.vue
: Enhanced styles for better visual consistency and added padding to theintervention-settings-section
class.