Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove model framework #5116

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Remove model framework #5116

merged 8 commits into from
Oct 15, 2024

Conversation

YohannParis
Copy link
Member

Description

  • This model wasn't used by anything or anyone

@dvince2
Copy link
Collaborator

dvince2 commented Oct 15, 2024

Why not also strike ModelFramework.java?

mwdchang
mwdchang approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@YohannParis YohannParis merged commit 92eee1d into main Oct 15, 2024
8 checks passed
@YohannParis YohannParis deleted the remove-model-framework branch October 15, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 approved these changes

@mwdchang mwdchang mwdchang approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey

@shawnyama shawnyama Awaiting requested review from shawnyama

@blanchco blanchco Awaiting requested review from blanchco

@asylves1 asylves1 Awaiting requested review from asylves1

Assignees

@dgauldie dgauldie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YohannParis @dvince2 @mwdchang @dgauldie