-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intervention validations #5159
Merged
Merged
Intervention validations #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S/3488-task-intervention-validations
Is this the right place to check?
…S/3488-task-intervention-validations
Tom-Szendrey
requested review from
dgauldie,
dvince2,
YohannParis,
mwdchang,
jryu01,
shawnyama,
blanchco and
asylves1
as code owners
October 16, 2024 15:34
dvince2
reviewed
Oct 16, 2024
...ftware/uncharted/terarium/hmiserver/models/simulationservice/interventions/Intervention.java
Outdated
Show resolved
Hide resolved
dvince2
previously requested changes
Oct 16, 2024
...ftware/uncharted/terarium/hmiserver/models/simulationservice/interventions/Intervention.java
Outdated
Show resolved
Hide resolved
.../uncharted/terarium/hmiserver/models/simulationservice/interventions/InterventionPolicy.java
Show resolved
Hide resolved
YohannParis
approved these changes
Oct 16, 2024
mwdchang
reviewed
Oct 16, 2024
...ftware/uncharted/terarium/hmiserver/models/simulationservice/interventions/Intervention.java
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
Oct 16, 2024
...ftware/uncharted/terarium/hmiserver/models/simulationservice/interventions/Intervention.java
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
Oct 16, 2024
.../uncharted/terarium/hmiserver/models/simulationservice/interventions/InterventionPolicy.java
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
Oct 17, 2024
.../uncharted/terarium/hmiserver/models/simulationservice/interventions/InterventionPolicy.java
Outdated
Show resolved
Hide resolved
update key to include atTheTime:
mwdchang
approved these changes
Oct 17, 2024
…S/3488-task-intervention-validations
Tom-Szendrey
dismissed
dvince2’s stale review
October 17, 2024 13:32
Requested changes that have been made and github doesnt realize?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Description
Follow up:
(I want to reduce how big the PR is for readability)
Will remove the menu in the side panel and add a trash symbol.
When user clicks on a card it will select it
When user clicks on the trash it will delete
Pictures: