Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clean]: Optimize Outdated TODOs #5175

Merged
merged 5 commits into from
Oct 17, 2024
Merged

[Clean]: Optimize Outdated TODOs #5175

merged 5 commits into from
Oct 17, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Oct 16, 2024 •
edited
Loading

Description

Functionally no differences

  • remove tooltips that had nothing filled in.
  • remove unreachable code that allows the user to save model configuration - not wanted anymore
  • remove outdated todo comments

@Tom-Szendrey Tom-Szendrey requested a review from mloppie October 16, 2024 20:44
@Tom-Szendrey Tom-Szendrey linked an issue Oct 16, 2024 that may be closed by this pull request
cleaning Optimize todos #5176
Closed
mwdchang
mwdchang approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@Tom-Szendrey Tom-Szendrey merged commit a42f28c into main Oct 17, 2024
4 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/clean-optimize-todo branch October 17, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloppie mloppie mloppie approved these changes

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees

@shawnyama shawnyama

@blanchco blanchco

@asylves1 asylves1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cleaning Optimize todos
6 participants
@Tom-Szendrey @mwdchang @mloppie @shawnyama @blanchco @asylves1