-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sympy parsing workaround for specific tokens #5178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwdchang
requested review from
YohannParis,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
October 18, 2024 15:18
YohannParis
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tom-Szendrey
approved these changes
Oct 18, 2024
blanchco
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work well
…arium into sympy-parsing-workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When rate-laws contain specific tokens sympy parsing tend to break as they are a part of reserved symbols. To parse them properly we encode them to something else, then revert them back when we need the parsing result.
So far, we have
For example:
Testing
Import this model
pascale-strata-problem-templates.json
You should be able to view it, open up parameter matrices, open up template matrices without causing JS errors.
Alternatively you can mess around in the engineering interface (http://localhost:8080/pyodide-test) ... note there are JS errors here because it does partial evaluations as you type, but the output (eval, symbols...etc) should make sense.
Closes #5161
Closes #5185