[BUG]: Better extraction failure notifications #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two fixes here. Firstly, for #5154 we now send up an error message for the front end with a comma seperated list of what extraction services failed. Secondly for #5123 we forgot to send a *Final* message in the failure case so the extraction just sat forever at its last reported % Resolves #5123 and #5154
kbirk
approved these changes
Oct 22, 2024
mwdchang
deleted the
5154-bug-pdf-extraction-fails-but-still-returns-success
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two fixes here. Firstly, for #5154 we now send up an error message for the front end with a comma seperated list of what extraction services failed. Secondly for #5123 we forgot to send a Final message in the failure case so the extraction just sat forever at its last reported %
Resolves ##5123 and #5154