Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dates to forecast charts #5255

Merged
merged 15 commits into from
Oct 25, 2024
Merged

add dates to forecast charts #5255

merged 15 commits into from
Oct 25, 2024

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Oct 23, 2024 •
edited
Loading

Description

  • If we have a time unit in the model and a defined start date within the model configuration, then show forecast charts as dates
Screenshot 2024-10-23 at 3 43 14 PM Screenshot 2024-10-23 at 3 43 00 PM Screenshot 2024-10-23 at 3 42 45 PM

@blanchco blanchco self-assigned this Oct 23, 2024
@blanchco blanchco marked this pull request as ready for review October 23, 2024 19:47
@blanchco blanchco removed the request for review from asylves1 October 23, 2024 19:47
@mwdchang mwdchang removed the request for review from YohannParis October 24, 2024 12:44
@blanchco blanchco mentioned this pull request Oct 24, 2024
Merged
@jryu01
Copy link
Contributor

jryu01 commented Oct 24, 2024 •
edited
Loading

I think AI annotation feature probably won't work for the charts with date type. We will need to update the prompt accordingly to reflect this change. I'm not exactly sure how good llm is for translating user entered date (for x value) and plot that in the chart though. We should handle that in a separate issue I think. @mwdchang @blanchco

@blanchco blanchco linked an issue Oct 25, 2024 that may be closed by this pull request
[TASK]: Adding dates to workflow Part 4 #5053
Closed
shawnyama
shawnyama reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@shawnyama shawnyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your second screenshot (the month graph) there are still some years, how do I know what month that year is on?

@blanchco
Copy link
Contributor Author

On your second screenshot (the month graph) there are still some years, how do I know what month that year is on?

That was using vegalite's system for dates, I've changed the labels to use our own format so it should show like Month, Year

@mwdchang mwdchang merged commit ecd792b into main Oct 25, 2024
4 checks passed
@mwdchang mwdchang deleted the add-date-to-forecast-charts branch October 25, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama approved these changes

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@mwdchang mwdchang mwdchang approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

Assignees

@mwdchang mwdchang

@jryu01 jryu01

@Tom-Szendrey Tom-Szendrey

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: Adding dates to workflow Part 4
5 participants
@blanchco @jryu01 @mwdchang @Tom-Szendrey @shawnyama