Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Small]: Limit preview on dataset node #5305

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Oct 25, 2024

Description

There is no limit on the preview in the dataset node.
This leads to HILARIOUS previews that make the node hard to work with and insane.

Problem:

image

Solution

show.more.less.mov

@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review October 25, 2024 17:19
@Tom-Szendrey Tom-Szendrey changed the title Limit preview on dataset node [Small]: Limit preview on dataset node Oct 25, 2024
@shawnyama
Copy link
Contributor

shawnyama commented Oct 25, 2024

does the show more option appear if you are to hover over the text? If you just want to show less you can just apply this css to the div the text used to be in

        white-space: pre-line;
	display: -webkit-box;
        -webkit-line-clamp: 5; /*Amount of lines you want here*/
	-webkit-box-orient: vertical;
	overflow: hidden;
	text-overflow: ellipsis;

@Tom-Szendrey Tom-Szendrey merged commit 4fc9920 into main Oct 25, 2024
4 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/limit-dataset-node branch October 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants