Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(funman): limit y range and round timepoints to third decimal place in preview #5308

Merged
merged 11 commits into from
Oct 30, 2024
Merged

fix(funman): limit y range and round timepoints to third decimal place in preview #5308

merged 11 commits into from
Oct 30, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 25, 2024 •
edited
Loading

Description

  • timepoints are rounded to third decimal place instead of rounded down to 0
  • limit y axis on graph to not go so far that it goes to NaN
Screen.Recording.2024-10-29.at.9.28.13.PM.mov

@shawnyama shawnyama linked an issue Oct 25, 2024 that may be closed by this pull request
[BUG]: Timepoint values in Validate configuration shown as integers #5293
Closed
@shawnyama shawnyama linked an issue Oct 29, 2024 that may be closed by this pull request
[BUG]: "Model check" boxes in Validate configuration do not match the given constraints #5292
Closed
@shawnyama shawnyama changed the title fix: rerun and timepoints preview fix(funman): limit y range and round timepoints to third decimal place in preview Oct 29, 2024
@shawnyama shawnyama marked this pull request as ready for review October 29, 2024 00:28
mwdchang
mwdchang approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's roll with the heuristic threshold for a few days and see how things look and reevaluate.

@mwdchang mwdchang merged commit e672ee2 into main Oct 30, 2024
4 checks passed
@mwdchang mwdchang deleted the funman-polish branch October 30, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@mwdchang mwdchang mwdchang approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shawnyama @mwdchang @Tom-Szendrey