Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(model-config-operator): rm guard preventing config select #5329

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix(model-config-operator): rm guard preventing config select #5329

merged 1 commit into from
Oct 29, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Oct 29, 2024 •
edited
Loading

Description

  • Model config select in the sidebar wasn't working
  • Remove guard expecting a document

@shawnyama shawnyama requested a review from asylves1 October 29, 2024 18:21
@shawnyama shawnyama marked this pull request as ready for review October 29, 2024 18:21
@shawnyama shawnyama merged commit 427164e into main Oct 29, 2024
4 checks passed
@shawnyama shawnyama deleted the fix-config-selection branch October 29, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanchco blanchco blanchco approved these changes

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawnyama @Tom-Szendrey @blanchco