Hook up new ES based DKG lookups #5309 #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooking up to the new Elasticseach hosted DKG. Right now this is just doing a basic text search over the title and description, with title taking priority. There is an issue logged to use embeddings to improve this search.
dvince2
requested review from
dgauldie,
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
dgauldie
reviewed
Nov 4, 2024
YohannParis
approved these changes
Nov 4, 2024
mwdchang
reviewed
Nov 4, 2024
...ages/server/src/main/java/software/uncharted/terarium/hmiserver/service/data/DKGService.java
Outdated
Show resolved
Hide resolved
…okups' into 5309-hook-up-new-es-based-dkg-lookups
mwdchang
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hooking up to the new Elasticseach hosted DKG. Right now this is just doing a basic text search over the title and description, with title taking priority. There is an issue logged to use embeddings to improve this search.
Resolves #5309