Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model config performance improvements #5374

Merged
merged 1 commit into from
Nov 4, 2024
Merged

model config performance improvements #5374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions ...lient/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
</template>
</tera-slider-panel>
</template>
<tera-drilldown-section :tabName="ConfigTabs.Wizard" class="px-3 mb-10">
<tera-drilldown-section :is-loading="initializing" :tabName="ConfigTabs.Wizard" class="px-3 mb-10">
<template #header-controls-left>
<tera-toggleable-input
v-if="typeof knobs.transientModelConfig.name === 'string'"
Expand Down Expand Up @@ -384,7 +384,7 @@ const confirm = useConfirm();
const filterModelConfigurationsText = ref('');
const filteredModelConfigurations = computed(() => {
const searchTerm = filterModelConfigurationsText.value.toLowerCase();
const filteredConfigurations = suggestedConfigurationContext.value.tableData.filter(
const filteredConfigurations = modelConfigurations.value.filter(
(config) =>
config.name?.toLowerCase().includes(searchTerm) || config.description?.toLowerCase().includes(searchTerm)
);
Expand Down Expand Up @@ -506,15 +506,9 @@ const datasetIds = computed(() =>
.filter((id): id is string => id !== undefined)
);

const suggestedConfigurationContext = ref<{
isOpen: boolean;
tableData: ModelConfiguration[];
modelConfiguration: ModelConfiguration | null;
}>({
isOpen: false,
tableData: [],
modelConfiguration: null
});
const modelConfigurations = ref<ModelConfiguration[]>([]);

const initializing = ref(false);
const isFetching = ref(false);
const isLoading = ref(false);

Expand Down Expand Up @@ -587,16 +581,17 @@ const onSaveConfiguration = async () => {

const fetchConfigurations = async (modelId: string) => {
isFetching.value = true;
suggestedConfigurationContext.value.tableData = await getModelConfigurationsForModel(modelId);
modelConfigurations.value = await getModelConfigurationsForModel(modelId);
isFetching.value = false;
};

// Fill the form with the config data
const initialize = async (overwriteWithState: boolean = false) => {
initializing.value = true;
const state = props.node.state;
const modelId = props.node.inputs[0].value?.[0];
if (!modelId) return;
await fetchConfigurations(modelId);
fetchConfigurations(modelId);

model.value = await getModel(modelId);
if (model.value) {
Expand All @@ -610,7 +605,7 @@ const initialize = async (overwriteWithState: boolean = false) => {

if (!state.transientModelConfig.id) {
// Apply a configuration if one hasn't been applied yet
applyConfigValues(suggestedConfigurationContext.value.tableData[0]);
applyConfigValues(modelConfigurations.value[0]);
} else {
originalConfig.value = await getModelConfigurationById(selectedConfigId.value);
if (!overwriteWithState) {
Expand All @@ -622,6 +617,7 @@ const initialize = async (overwriteWithState: boolean = false) => {

configuredMmt.value = makeConfiguredMMT(mmt.value, knobs.value.transientModelConfig);

initializing.value = false;
// Create a new session and context based on model
try {
const jupyterContext = buildJupyterContext();
Expand Down Expand Up @@ -719,14 +715,14 @@ const updateThoughts = (data: any) => {

watch(
() => props.node.state.modelConfigTaskIds,
async (watchVal) => {
if (watchVal.length > 0) {
(newValue, oldValue) => {
if (newValue.length > 0) {
isLoading.value = true;
} else {
} else if (newValue.length !== oldValue.length) {
isLoading.value = false;
const modelId = props.node.inputs[0].value?.[0];
if (!modelId) return;
await fetchConfigurations(modelId);
fetchConfigurations(modelId);
}
}
);
Expand Down