Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5350 [part 2] fixes permanently disabled "save for reuse" button #5412

Conversation

mloppie
Copy link
Contributor

@mloppie mloppie commented Nov 6, 2024

There are really 3 bugs in #5350, I am submitting the fixes for them separately for clarity and ease of review

  • Fixes the permanent invalid state of the node to allow saving
  • Preserves the ability to disable saving when actually invalid
Screenshot 2024-11-06 at 3 03 52 PM

Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test this but cant see what would be wrong with it

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…for-reuse-add-cell-button-not-working-yellow-header-always-there-part2
@dgauldie dgauldie merged commit 511f397 into main Nov 7, 2024
4 checks passed
@dgauldie dgauldie deleted the 5350-bug-cant-save-a-dataframe-as-a-dataset-for-reuse-add-cell-button-not-working-yellow-header-always-there-part2 branch November 7, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants