Have interventions, variables, and comparison charts across all ta3 operators. #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryu/update-output-settings
jryu01
requested review from
YohannParis,
mwdchang,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
Tom-Szendrey
approved these changes
Nov 11, 2024
mwdchang
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure following charts and the settings are in all calibrate, optimize, and simulate operators.
Calibrate - Added comparison charts
Optimize - Added comparison charts
Simulation - Added intervention and variable charts
And small UI change to show the variable name in the chart settings panel
Note: There are many repetitions of certain logics across multiple components regarding charts and output settings. I'll do refactoring and make them reusable to remove duplicates in a separate PR.
Resolves #5170