Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5350 bug cant save a dataframe as a dataset for reuse add cell button not working yellow header always there part 3 #5432

Conversation

mloppie
Copy link
Contributor

@mloppie mloppie commented Nov 8, 2024

There are really 3 bugs in #5350, I am submitting the fixes for them separately for clarity and ease of review

  • Bubbles a dirty flag when the code in the editor changes to show the rerun banner at the appropriate time

Resolves #5350

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mwdchang mwdchang merged commit 79ffd30 into main Nov 8, 2024
4 checks passed
@mwdchang mwdchang deleted the 5350-bug-cant-save-a-dataframe-as-a-dataset-for-reuse-add-cell-button-not-working-yellow-header-always-there-part-3 branch November 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Can't save a dataframe as a dataset for reuse, Add cell button not working, yellow header always there
3 participants