Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability allow only 1 unique asset id in an input #5447

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Nov 8, 2024

Description

  • Adding a unique flag to the inputs so that we can check if we can add multiple of that value to the target port.
  • Allows us to only connect unique model configs (or any other asset ids) into target ports

Edit

  • Now a user can define whether or not the inputs are unique at an operator level by using the uniqueInputs key

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should the uniqueness of an input be managed byt the node directly, and we should not have to precise that on the emit add input port.

@blanchco blanchco merged commit 65c1466 into main Nov 11, 2024
4 checks passed
@blanchco blanchco deleted the unique-value-inputs branch November 11, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants