Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensemble Simulate - same typing as ensemble calibrate #5458

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Ensemble Simulate - same typing as ensemble calibrate #5458

merged 4 commits into from
Nov 12, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Nov 11, 2024 •
edited
Loading

Description

  • Ensemble simulate now has the same mapping type as the calibration does.
  • Now requires unique inputs
  • provide a type for modelConfigIdToNameMap
  • correct state updater via knobs as watcher should be deep not immediate

@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review November 11, 2024 20:52
YohannParis
YohannParis approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tom-Szendrey Tom-Szendrey merged commit 8ab855e into main Nov 12, 2024
4 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/ensemble-simulate-map-change branch November 12, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis YohannParis approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees

@YohannParis YohannParis

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tom-Szendrey @YohannParis @mwdchang @blanchco