Calibration loss chart missing #5459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Szendrey
requested review from
YohannParis,
mwdchang,
jryu01,
shawnyama,
blanchco and
asylves1
as code owners
shawnyama
approved these changes
Nov 12, 2024
This was
unlinked from
issues
Nov 12, 2024
mwdchang
reviewed
Nov 12, 2024
...rc/components/workflow/ops/calibrate-ensemble-ciemss/tera-calibrate-ensemble-node-ciemss.vue
Outdated
Show resolved
Hide resolved
mwdchang
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had calibration chart
!lossChartRef.value?.viewas well asv-if="!_.isEmpty(lossValues)"so we wont fill the data unless we have the reference assigned, but we wont assign the reference unless we have data
Take loss chart outside of inner result template in the node.
[Minor]: Do not await a const when using
updateLossChartSpec