-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: paginate model entries for better performance #5461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence, pagination is the way
shawnyama
requested review from
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
blanchco and
asylves1
as code owners
November 13, 2024 17:26
YohannParis
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, and neatily done!
packages/client/hmi-client/src/components/model/petrinet/tera-initial-table.vue
Show resolved
Hide resolved
mwdchang
reviewed
Nov 13, 2024
packages/client/hmi-client/src/components/model/petrinet/tera-petrinet-parts.vue
Outdated
Show resolved
Hide resolved
mwdchang
reviewed
Nov 13, 2024
packages/client/hmi-client/src/components/model/model-parts/tera-model-part.vue
Show resolved
Hide resolved
mwdchang
reviewed
Nov 13, 2024
packages/client/hmi-client/src/components/model/model-parts/tera-model-part.vue
Show resolved
Hide resolved
mwdchang
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tera-toggleable-input
to see if not always having an active input box will help out but it didn't make any noticeable difference in memory usageScreen.Recording.2024-11-13.at.12.22.02.PM.mov
Small cleanups:
tera-model-part.vue
to support showing the filtered items I realized that there was no point in the watcher we have in thereBenchmark comparison
Side note:
Adding pagination saved some memory but the model diagram and equations are taking up a lot too, the page will crash if you open the expanded view of this model