Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor charts and settings across calibrate, optimize and simulate nodes and drilldowns #5476

Merged
merged 17 commits into from
Nov 14, 2024
Merged

Refactor charts and settings across calibrate, optimize and simulate nodes and drilldowns #5476

merged 17 commits into from
Nov 14, 2024

Conversation

jryu01
Copy link
Contributor

@jryu01 jryu01 commented Nov 12, 2024

Description

Refactored charts and settings across the calibrate, optimize, and simulate nodes and drilldowns to reduce duplicate code.

  • Extracted logic for managing chartSettings state into a reusable composable, useChartSettings.ts.
  • Extracted chart specification preparation logic for each chart setting type into useCharts.ts.
  • Moved chart data preparation logic for each operator into separate utility files, allowing shared use between nodes and drilldowns.

@jryu01 jryu01 marked this pull request as ready for review November 12, 2024 20:19
Tom-Szendrey
Tom-Szendrey approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!!

@mwdchang mwdchang merged commit 0dc378d into main Nov 14, 2024
4 checks passed
@mwdchang mwdchang deleted the jryu/refactor-output-setttings branch November 14, 2024 02:08
@mwdchang mwdchang mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@YohannParis YohannParis YohannParis left review comments

@mwdchang mwdchang mwdchang approved these changes

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jryu01 @YohannParis @mwdchang @Tom-Szendrey