New intervention not working #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blanchco
reviewed
Nov 13, 2024
...lient/src/components/workflow/ops/intervention-policy/tera-intervention-policy-drilldown.vue
Outdated
Show resolved
Hide resolved
Tom-Szendrey
requested review from
YohannParis,
mwdchang,
jryu01,
shawnyama and
asylves1
as code owners
Tom-Szendrey
commented
Nov 14, 2024
Tom-Szendrey
commented
Nov 14, 2024
...lient/src/components/workflow/ops/intervention-policy/tera-intervention-policy-drilldown.vue
Show resolved
Hide resolved
mwdchang
approved these changes
Nov 14, 2024
shawnyama
approved these changes
Nov 14, 2024
blanchco
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the workflow for creating a new intervention is that we would POST a blank intervention and any updates would then allow the user to update this newly created intervention.
This is not a valid workflow as the blank intervention is not a valid intervention (It has no timestep and no value) thus it fails HMIServer's validation.
The new workflow is that we will reset the interface on the frontend and wait for the user to hit
SaveorSave as...before trying to POST this interventionIntervention.Create.New.mov