Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scenario templates #5490

Merged
merged 13 commits into from
Nov 14, 2024
Merged

scenario templates #5490

merged 13 commits into from
Nov 14, 2024

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Nov 13, 2024 •
edited
Loading

Description

  • kick off for scenario templates

templates:

  • Blank template
  • Situational Awareness

TODO:

  • template storage

@blanchco blanchco self-assigned this Nov 13, 2024
@blanchco blanchco linked an issue Nov 13, 2024 that may be closed by this pull request
[TASK]: Scenario Templates: Template data structure #5495
Closed
@blanchco blanchco marked this pull request as ready for review November 13, 2024 21:12
@blanchco blanchco requested review from Tom-Szendrey and removed request for jryu01, Tom-Szendrey and asylves1 November 13, 2024 21:12
Cole Blanchard added 2 commits November 13, 2024 16:44
YohannParis
YohannParis reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a really convulated and strange way to create templates.
I'm not part of that feature planning, so I will restrain to approve on this PR.
I will not comment on how the forms layout has been made, but it will need some cleaning up once this is done and fully functional.

packages/client/hmi-client/src/components/project/tera-resource-sidebar.vue Outdated Show resolved Hide resolved
packages/client/hmi-client/src/components/workflow/scenario-templates/scenario-template.ts Outdated Show resolved Hide resolved
...mponents/workflow/scenario-templates/situational-awareness/situational-awareness-template.ts Outdated Show resolved Hide resolved
...ts/workflow/scenario-templates/situational-awareness/tera-situational-awareness-template.vue Show resolved Hide resolved
...ts/workflow/scenario-templates/situational-awareness/tera-situational-awareness-template.vue Outdated Show resolved Hide resolved
mwdchang
mwdchang approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a great start

Tom-Szendrey
Tom-Szendrey approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@blanchco blanchco merged commit 51c31b1 into main Nov 14, 2024
4 checks passed
@blanchco blanchco deleted the scenario-templates branch November 14, 2024 20:01
shawnyama
shawnyama reviewed Nov 14, 2024
View reviewed changes
...ts/workflow/scenario-templates/situational-awareness/tera-situational-awareness-template.vue
Comment on lines +111 to +116
const modelOptions: any[] = model.model.states;

model.semantics?.ode.observables?.forEach((o) => {
modelOptions.push(o);
});
modelStateOptions.value = modelOptions;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const modelOptions: any[] = model.model.states;
model.semantics?.ode.observables?.forEach((o) => {
modelOptions.push(o);
});
modelStateOptions.value = modelOptions;
modelStateOptions.value = [...model.model.states, ...model.semantics?.ode.observables];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama left review comments

@YohannParis YohannParis YohannParis left review comments

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@mwdchang mwdchang mwdchang approved these changes

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: Scenario Templates: Template data structure
5 participants
@blanchco @YohannParis @mwdchang @Tom-Szendrey @shawnyama