Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5450 create a sample project #5492

Merged
merged 44 commits into from
Nov 15, 2024
Merged

5450 create a sample project #5492

merged 44 commits into from
Nov 15, 2024

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Nov 13, 2024 •
edited
Loading

Description

  • Add a boolean sampleProject to the Project.java
  • Update the controller to allow Admins to make a project a sample project. This will make the project public, then will remove all previous permissions relationship to it. Only Admin can edit it.
  • Display sample project in the right tab on the front-end.
  • Allow admin to make a project a sample project

@YohannParis YohannParis linked an issue Nov 13, 2024 that may be closed by this pull request
Create a sample project #5450
Closed
github-actions bot and others added 15 commits November 13, 2024 20:57
@YohannParis YohannParis marked this pull request as ready for review November 13, 2024 22:01
@bigglesandginger
Copy link
Contributor

Added change to Project.java so that sampleProject boolean is actually saved anywhere.

The UI does not show Sample Projects in the sample project tab

dvince2
dvince2 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@dvince2 dvince2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok but I will defer to @bigglesandginger on rebac magic

@YohannParis YohannParis merged commit b076729 into main Nov 15, 2024
5 of 7 checks passed
@YohannParis YohannParis deleted the 5450-create-a-sample-project branch November 15, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 approved these changes

@bigglesandginger bigglesandginger bigglesandginger approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees

@dgauldie dgauldie

@bigglesandginger bigglesandginger

@dvince2 dvince2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a sample project
4 participants
@YohannParis @bigglesandginger @dvince2 @dgauldie