Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct optimize created interventions #5524

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Correct optimize created interventions #5524

merged 6 commits into from
Nov 15, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey commented Nov 15, 2024 •
edited
Loading

Description

  • Optimize returns results as list this needed to be updated to reflect that
  • Add more typing for readability

Testing:

Run optimize and check that the result is a properly formatted intervention
You can run with one or many interventions
You can select any type of (start time, param value, both)

@Tom-Szendrey Tom-Szendrey linked an issue Nov 15, 2024 that may be closed by this pull request
Correct Optimize intervention builder #5523
Closed
@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review November 15, 2024 19:45
@Tom-Szendrey Tom-Szendrey marked this pull request as draft November 15, 2024 19:47
@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review November 15, 2024 20:02
@Tom-Szendrey Tom-Szendrey merged commit dbeed30 into main Nov 15, 2024
8 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/correct-optimize-created-interventions branch November 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 approved these changes

@mwdchang mwdchang mwdchang approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct Optimize intervention builder
3 participants
@Tom-Szendrey @mwdchang @dvince2