Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensemble Calibrate fix up stop button #5611

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Ensemble Calibrate fix up stop button #5611

merged 1 commit into from
Nov 25, 2024

Conversation

Tom-Szendrey
Copy link
Contributor

Description

  • Add error messages to ensemble calibrate if we run into a failure.
  • Update cancelId to include all sim ids
  • if we stop the poller we do not need to also check for errors. This should be else if not if

@Tom-Szendrey Tom-Szendrey marked this pull request as ready for review November 22, 2024 16:05
@Tom-Szendrey Tom-Szendrey linked an issue Nov 22, 2024 that may be closed by this pull request
[BUG]: "Stop" Button behaving strangely #3955
Closed
mwdchang
mwdchang approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did test, code looks okay

@Tom-Szendrey Tom-Szendrey merged commit e76ec2c into main Nov 25, 2024
4 checks passed
@Tom-Szendrey Tom-Szendrey deleted the TS/ensemble-cali-cancel-button branch November 25, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanchco blanchco blanchco approved these changes

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: "Stop" Button behaving strangely
3 participants
@Tom-Szendrey @mwdchang @blanchco