Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove feature config where applicable #5620

Merged
merged 3 commits into from
Nov 25, 2024
Merged

remove feature config where applicable #5620

merged 3 commits into from
Nov 25, 2024

Conversation

blanchco
Copy link
Contributor

Description

  • Remove the feature-config object where applicable for tera-asset
  • There are a number of components that do actually use featureConfig still so I have left those alone for now. It might be worth it to make the prop simply a boolean rather than this object for those components though.

@blanchco blanchco self-assigned this Nov 25, 2024
@blanchco blanchco linked an issue Nov 25, 2024 that may be closed by this pull request
[TASK]: remove isPreview and FeatureConfig prop #5259
Closed
YohannParis
YohannParis approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing ⭐

@blanchco blanchco merged commit b1aa592 into main Nov 25, 2024
4 checks passed
@blanchco blanchco deleted the tera-asset-cleanup/remove-feature-config branch November 25, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asylves1 asylves1 asylves1 approved these changes

@shawnyama shawnyama shawnyama approved these changes

@YohannParis YohannParis YohannParis approved these changes

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: remove isPreview and FeatureConfig prop
4 participants
@blanchco @YohannParis @shawnyama @asylves1