Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup project table layout logic and css #5683

Merged
merged 23 commits into from
Nov 29, 2024
Merged

cleanup project table layout logic and css #5683

merged 23 commits into from
Nov 29, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Nov 28, 2024 •
edited
Loading

Description

  • settled on table column widths
  • no more weird horizontal scrollbar when the window width is small
  • put the tera-project-menu beside the title for more column space
  • organized css
  • simplified logic for displaying stats

image

@shawnyama
layout adjust
289674f
@shawnyama
highlight assets
39e7bc7
@shawnyama
resolve conflicts
dcdce64
@shawnyama
maintain page state
b2dae49
@shawnyama
sticky header hype
16167a5
@shawnyama
sticky paginator lol
140a2a6
@shawnyama
search button, efficient project asset updates and reset to first pag…
6f74809 
…e on new search
@shawnyama
Merge branch 'main' into knn-project-search
682bd2c
@shawnyama
show more show less for list
d15cbe8
@shawnyama
Merge branch 'main' into knn-project-search
0579f7b
@shawnyama
edge case
6370978
@shawnyama
Merge branch 'knn-project-search' of https://github.com/DARPA-ASKEM/t…
936ab9c 
…erarium into knn-project-search
@shawnyama
dan comments
39fb6c1
@shawnyama
move project menu by title and make map for widths
688d90d
@shawnyama
uuid trick
4dc8d1e
@shawnyama
clean/organize css and simplify stats logic
99b202f
@shawnyama
rm func
fc3636a
@shawnyama
decide column widths
cc02da7
@shawnyama
unify truncate text rules
d45787c
@shawnyama
add focus rule back
a564936
Base automatically changed from knn-project-search to main November 29, 2024 04:42
@shawnyama shawnyama marked this pull request as ready for review November 29, 2024 14:00
blanchco
blanchco approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@blanchco blanchco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@shawnyama shawnyama merged commit 65823ec into main Nov 29, 2024
4 checks passed
@shawnyama shawnyama deleted the cleanup-table-columns branch November 29, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanchco blanchco blanchco approved these changes

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees

@blanchco blanchco

@asylves1 asylves1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shawnyama @YohannParis @blanchco @asylves1