Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intervention node - show summary card and selectable node chart #5747

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Intervention node - show summary card and selectable node chart #5747

merged 3 commits into from
Dec 5, 2024

Conversation

asylves1
Copy link
Contributor

@asylves1 asylves1 commented Dec 4, 2024 •
edited
Loading

Description

Design Change:

  • enable the add the summary cards for the interventions
  • enable user to choose which charts to show on the intervention node

Screenshot 2024-12-04 at 2 06 56 PM
Screenshot 2024-12-04 at 2 07 20 PM

Testing:

  • Create a few new interventions
  • select the charts you wish to see on the node
  • all interventions should appear as summary with the selected charts

Resolves #(issue)

@asylves1 asylves1 linked an issue Dec 4, 2024 that may be closed by this pull request
[FEAT]: Too many charts show up as thumbnail of the "Create intervention policy" operator - should user-selected and/or capped #5659
Closed
@asylves1 asylves1 changed the title Intervention select node chart Intervention node - show summary card and selectable node chart Dec 4, 2024
@asylves1 asylves1 marked this pull request as ready for review December 4, 2024 19:08
@mwdchang mwdchang merged commit 8b4e8e0 into main Dec 5, 2024
4 checks passed
@mwdchang mwdchang deleted the intervention-select-node-chart branch December 5, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgauldie dgauldie dgauldie approved these changes

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asylves1 @mwdchang @dgauldie