Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compare datasets graphs #5758

Merged
merged 19 commits into from
Dec 5, 2024
Merged

compare datasets graphs #5758

merged 19 commits into from
Dec 5, 2024

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Dec 5, 2024 •
edited
Loading

Description

  • first pass for compare datasets (merged with @blanchco's work)
  • rendering compare graphs; in the image here I am comparing the same datasets due to them conveniently having the same column names, I just added 1 to the other dataset's values to show two lines as if they are different
  • moved getRawCsv function to dataset service

image

@shawnyama shawnyama marked this pull request as ready for review December 5, 2024 20:43
@dgauldie dgauldie merged commit 23195e5 into main Dec 5, 2024
2 checks passed
@dgauldie dgauldie deleted the wizard-compare-datasets branch December 5, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blanchco blanchco blanchco approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawnyama @blanchco @dgauldie