Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: model config observables list #5801

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Bug: model config observables list #5801

merged 1 commit into from
Dec 10, 2024

Conversation

asylves1
Copy link
Contributor

Description

Issue:

  • The wrong object was being passed to tera-model-parts.vue causing the model config to stop functioning correctly
    • the drill down can no longer be closed

Testing:

  • using this model create a model config and trying making changes
  • SIR to validate
    Resolves #(issue)

@asylves1 asylves1 linked an issue Dec 10, 2024 that may be closed by this pull request
Bug: Errors & Warnings appearing when opening model config #5798
Closed
@asylves1 asylves1 marked this pull request as ready for review December 10, 2024 20:02
@asylves1 asylves1 changed the title fix for wrong object being passed Bug: model config observables List Dec 10, 2024
@asylves1 asylves1 changed the title Bug: model config observables List Bug: model config observables list Dec 10, 2024
@mwdchang mwdchang merged commit 51f6876 into main Dec 10, 2024
4 checks passed
@mwdchang mwdchang deleted the bug-model-config-observables branch December 10, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnyama shawnyama shawnyama approved these changes

@mwdchang mwdchang mwdchang approved these changes

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

Assignees

@shawnyama shawnyama

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Errors & Warnings appearing when opening model config
4 participants
@asylves1 @mwdchang @shawnyama @blanchco