Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5663 look into simulate operator for polling spinner #5810

Merged
merged 26 commits into from
Dec 16, 2024
Merged

5663 look into simulate operator for polling spinner #5810

merged 26 commits into from
Dec 16, 2024

Conversation

mloppie
Copy link
Contributor

@mloppie mloppie commented Dec 11, 2024

Description

  • Fixes the simulate node spinner by switching to polling from notifications.
  • Also fixes the simulate drilldown spinner, previously it would not appear on the first click of Run.
  • Elevates the spinner and blank graphics to the drilldown section component
  • Remove spinner and blank in various places to reuse the one in drilldown section
  • Changes the poller default threshold and interval to require fewer params in most cases

Resolves #5663

@mloppie mloppie linked an issue Dec 11, 2024 that may be closed by this pull request
Look into Simulate Operator for polling + spinner #5663
Closed
@Tom-Szendrey
Copy link
Contributor

Just confirming @mloppie on your branch while running ensemble calibrate I do see the loss values:

Seeing.ensemble.calibrate.loss.mov

This was referenced Dec 16, 2024
Closed
Closed
Tom-Szendrey
Tom-Szendrey approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my current comments this looks good
Thank you for this

@mloppie mloppie merged commit 5a142d5 into main Dec 16, 2024
4 checks passed
@mloppie mloppie deleted the 5663-look-into-simulate-operator-for-polling-spinner branch December 16, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang left review comments

@shawnyama shawnyama shawnyama approved these changes

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@YohannParis YohannParis YohannParis approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Look into Simulate Operator for polling + spinner
5 participants
@mloppie @Tom-Szendrey @YohannParis @mwdchang @shawnyama