Refactor and improve active chart settings panel and useChartSettings composable #5847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some refactoring related to usChartSettings and active chart settings panel
activeChartSettings
as computed property instead of ref to prevent direct modification from componentssetActiveChartSettings
method to set or unset active chart settingsfindAndUpdateChartSettingsById
method to find and update chart settings with partial payload instead of having own update method for each chart setting property.activeChartSettings
is reactive and updated properly whenchartSettings
update.Resolves #(issue)