Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and improve active chart settings panel and useChartSettings composable #5847

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

jryu01
Copy link
Contributor

@jryu01 jryu01 commented Dec 16, 2024

Description

Some refactoring related to usChartSettings and active chart settings panel

  • Expose activeChartSettings as computed property instead of ref to prevent direct modification from components
  • setActiveChartSettings method to set or unset active chart settings
  • findAndUpdateChartSettingsById method to find and update chart settings with partial payload instead of having own update method for each chart setting property.
  • Make sure activeChartSettings is reactive and updated properly when chartSettings update.
  • Added default primary color to the new settings

Resolves #(issue)

@jryu01 jryu01 marked this pull request as ready for review December 16, 2024 15:56
@jryu01 jryu01 requested a review from mloppie as a code owner December 16, 2024 19:16
@jryu01 jryu01 merged commit 5205353 into main Dec 16, 2024
4 checks passed
@jryu01 jryu01 deleted the jryu/active-settings-reactivity branch December 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants