-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use gollm=>mira equation to amr pipeline #5851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the debug in equations-to-model-debug
?
@Tom-Szendrey I want to flag it as not meant to be used aside from debugging. The current pipeline is not very transparent, it has 3-4 junctions (llm-enrichment, llm-code-gen, code-eval to sympy, ode-to-amr) where things can go wrong but not really set up to report errors at each stage. Because it is also coupled with SKEMA stuff and model enrichment, and is used as a one-shot model creation process in the UI, it is just not ideal to refactor it until we agree on a more sane process. So for now we have a debugging analog. |
Thank you for filling me in! |
Summary
Replace
latex => sympy.parse_latex => mira
pipeline withlatex => gollm => mira
pipeline.This is the 2nd part to: #5846
This PR also clean up the mira-endpoint.
/mira/latex-to-amr
=>/knowledge/equations-to-model-debug
Testing
POST
/knowledge/equations-to-model
should return a model-id, which in turn should reflect the equations.