Jamie add dragndrop upload file zone to resource panel #5989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiewaese-uncharted
requested review from
YohannParis,
mwdchang,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco,
asylves1 and
mloppie
as code owners
mwdchang
approved these changes
Jan 10, 2025
mwdchang
deleted the
jamie-add-dragndrop-upload-file-zone-to-resource-panel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE
In order to upload a file, you had to click the "Upload" button in the resource panel then drag files into the drop zone in the "Upload resources" modal. It's a pretty typical UX flow and it's fine.
A few months ago Yohann suggested that it would be cool if we could also drag files directly onto the resource panel. This is a step in that direction.
This also addresses a separate issue: When we have two or three uploads in the cue, and then we add one more, the upload status bar gets displayed on all the files, not just the one that's uploading. It's just messy.
AFTER
This feature enables files to be dropped directly into the resources panel. They get passed through to the upload file modal and get uploaded as if you had dropped it into the drop zone in the modal.
Also, I fixed the status bar issue so that we only show one.