Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataset mapping in compare datasets #6444

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Fix dataset mapping in compare datasets #6444

merged 7 commits into from
Feb 6, 2025

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Feb 5, 2025 •
edited
Loading

Description

  • mapping shows expecting variable name format (not pyciemss)
  • generate mapping options in onMounted instead of in html
  • higher compatibility for mapping different variable names
  • this is half the battle of solving this, regular dataset assets aren't supported in compare datasets so I'll see what I can do in a second pass

image

@shawnyama shawnyama changed the title Fix dataset mapping Fix dataset mapping in compare datasets Feb 5, 2025
@shawnyama shawnyama linked an issue Feb 5, 2025 that may be closed by this pull request
[BUG]: Dataset vars do not show up in compare dataset when comparing model errors #6348
Closed
@shawnyama shawnyama changed the base branch from main to release/v2.31.0 February 5, 2025 19:19
@shawnyama shawnyama changed the base branch from release/v2.31.0 to main February 5, 2025 19:21
@shawnyama shawnyama changed the base branch from main to release/v2.31.0 February 5, 2025 19:26
@shawnyama shawnyama marked this pull request as draft February 5, 2025 19:32
@shawnyama shawnyama removed a link to an issue Feb 5, 2025
[BUG]: Dataset vars do not show up in compare dataset when comparing model errors #6348
Closed
@shawnyama shawnyama marked this pull request as ready for review February 5, 2025 20:55
@shawnyama shawnyama linked an issue Feb 5, 2025 that may be closed by this pull request
[TASK]: variables should be regular (not pyciemss) and show variables from regular dataset #6452
Closed
Base automatically changed from release/v2.31.0 to main February 6, 2025 15:52
@shawnyama shawnyama changed the base branch from main to release/v2.31.0 February 6, 2025 16:01
@shawnyama shawnyama merged commit 0b63742 into release/v2.31.0 Feb 6, 2025
@shawnyama shawnyama deleted the fix-dataset-mapping branch February 6, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang left review comments

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@mloppie mloppie Awaiting requested review from mloppie mloppie is a code owner

Assignees

@Tom-Szendrey Tom-Szendrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: variables should be regular (not pyciemss) and show variables from regular dataset
3 participants
@shawnyama @mwdchang @Tom-Szendrey