New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison chart colour selection #6488

Merged

asylves1 merged 10 commits into main from color-picker-comparison-chart

Feb 10, 2025

Contributor

asylves1 commented Feb 7, 2025

Description

Design Change:

Enable Colour Selection for Comparison Chart

Testing:

Create a Simulate
Add a Comparison Chart
click on the setting cog for the chart in the side panel
change colour for one of the variable

Resolves #(issue)

asylves1 and others added 3 commits

February 7, 2025 01:07


          comparison chart colour selection

b7a5f6e


          Merge branch 'main' into color-picker-comparison-chart

dd3238d


          clean up

f923223

asylves1 marked this pull request as ready for review

February 7, 2025 14:17

asylves1 requested review from YohannParis, mwdchang, jryu01, Tom-Szendrey, shawnyama, blanchco and mloppie as code owners

February 7, 2025 14:17

asylves1 assigned jryu01, YohannParis, shawnyama and blanchco

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/composables/useCharts.ts Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/components/widgets/tera-chart-settings.vue Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/components/widgets/tera-chart-settings-panel.vue Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/components/widgets/tera-chart-settings-panel.vue Outdated Show resolved Hide resolved

jryu01 reviewed

View reviewed changes

packages/client/hmi-client/src/components/widgets/tera-chart-settings-panel.vue Outdated Show resolved Hide resolved

asylves1 and others added 5 commits

February 7, 2025 15:40


          suggested PR changes

322a82c


          clean up

fce6140


          Merge branch 'main' into color-picker-comparison-chart

d0a2068


          fix for color not updating

11c7765


          fix for multi chart

36caac5

jryu01 approved these changes

View reviewed changes


          Merge branch 'main' into color-picker-comparison-chart

ffb978f

Contributor

jryu01 commented Feb 10, 2025

Note: #6547 needs to be reviewed and merged to this branch.


          Fixes issue that color is resetting (#6547)

44a0ad4

blanchco approved these changes

View reviewed changes

asylves1 linked an issue

that may be closed by this pull request

Add colour picker to comparison chart #6380

Closed

asylves1 merged commit 339c21c into main

4 checks passed

asylves1 deleted the color-picker-comparison-chart branch

February 10, 2025 15:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jryu01 jryu01 approved these changes

blanchco blanchco approved these changes

YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

shawnyama Awaiting requested review from shawnyama

mloppie Awaiting requested review from mloppie mloppie is a code owner

Labels

None yet