New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint #6580

Merged

YohannParis merged 12 commits into main from lint

Feb 13, 2025

Contributor

mloppie commented Feb 12, 2025

Description

Mostly commenting out imports if they're used in commented out code and deleting imports if they are actually not used

mloppie added 5 commits

February 12, 2025 11:22


          code cleanup

9d8a94c


          code cleanup

48ec858


          show dates in tooltip when possible

f7dccc4


          Merge branch 'main' into 5964-task-add-date-formatting-to-forecast-ch…

3b3bcaf

…art-tooltip-if-relevant


          lint

88e2c4c

mloppie requested review from dgauldie, dvince2, YohannParis, mwdchang, jryu01, Tom-Szendrey and blanchco as code owners

February 12, 2025 20:14


          Merge branch 'main' into lint

c9bbe89

dvince2 reviewed

View reviewed changes

...es/server/src/main/java/software/uncharted/terarium/hmiserver/controller/AuthController.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

.../main/java/software/uncharted/terarium/hmiserver/controller/dataservice/ModelController.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...main/java/software/uncharted/terarium/hmiserver/controller/permissions/GroupsController.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

.../java/software/uncharted/terarium/hmiserver/security/KeycloakJwtAuthenticationConverter.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...ages/server/src/main/java/software/uncharted/terarium/hmiserver/security/SecurityConfig.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...ages/server/src/main/java/software/uncharted/terarium/hmiserver/service/data/DKGService.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...es/server/src/main/java/software/uncharted/terarium/hmiserver/service/data/ModelService.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...n/java/software/uncharted/terarium/hmiserver/service/tasks/EnrichDatasetResponseHandler.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...ware/uncharted/terarium/hmiserver/service/tasks/InterventionsFromDatasetResponseHandler.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...ware/uncharted/terarium/hmiserver/service/tasks/InterventionsFromDatasetResponseHandler.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...are/uncharted/terarium/hmiserver/service/tasks/InterventionsFromDocumentResponseHandler.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

.../main/java/software/uncharted/terarium/hmiserver/service/tasks/ModelCardResponseHandler.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

.../server/src/main/java/software/uncharted/terarium/hmiserver/service/tasks/TaskUtilities.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...ava/software/uncharted/terarium/hmiserver/controller/dataservice/DatasetControllerTests.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...ava/software/uncharted/terarium/hmiserver/controller/knowledge/KnowledgeControllerTests.java Outdated Show resolved Hide resolved

dvince2 reviewed

View reviewed changes

...rver/src/test/java/software/uncharted/terarium/hmiserver/service/ExtractionServiceTests.java Outdated Show resolved Hide resolved

dvince2 approved these changes

View reviewed changes

Collaborator

dvince2 left a comment

Let me tell you I LOVE prs like this haha :D

I'm in favour of going more - I think anything with a @SuppressWarnings("unused") we can pretty much get rid of.

mloppie and others added 6 commits

February 12, 2025 15:28


          Merge branch 'main' into lint

60f4e7d


          more lint

43573cf


          fix too aggressive delinting

9cebf4b


          Merge branch 'main' into lint

6e0a682


          ModelService Cleanup

c788f95


          Merge branch 'main' into lint

2f59ba6

YohannParis approved these changes

View reviewed changes

YohannParis merged commit f454853 into main

5 checks passed

YohannParis deleted the lint branch

February 13, 2025 16:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dvince2 dvince2 approved these changes

YohannParis YohannParis approved these changes

dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

mwdchang Awaiting requested review from mwdchang

jryu01 Awaiting requested review from jryu01

Tom-Szendrey Awaiting requested review from Tom-Szendrey

blanchco Awaiting requested review from blanchco

Labels

None yet