Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up sidebar #942

Merged
merged 12 commits into from
Apr 3, 2023

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Mar 31, 2023

Description

  • Add numbers of assets in accordion
  • Fix issue of opening two overview tabs for no reasons
  • Remove unused components
  • Added assets count to overview tab
  • Fix issue where tabs where using xdd_uri instead of assetId.
  • Rename props of Document.vue to match content.

Details

Screen.Recording.2023-03-31.at.14.00.09.mov

@YohannParis YohannParis linked an issue Mar 31, 2023 that may be closed by this pull request
@YohannParis YohannParis marked this pull request as ready for review March 31, 2023 21:14
@YohannParis YohannParis requested a review from mwdchang as a code owner March 31, 2023 21:14
@mwdchang
Copy link
Member

mwdchang commented Apr 3, 2023

Code looks fine, didn't test - I assume you resolved the TDS integer vs uuid issue?

@YohannParis YohannParis merged commit 831c72a into main Apr 3, 2023
@YohannParis YohannParis deleted the 939-task-tidy-up-tabs-and-assets-in-project branch April 3, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants