Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move pdf download button to Document.vue #948

Merged
merged 7 commits into from
Apr 3, 2023
Merged

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Apr 3, 2023

Description

PDF download button appears in Document.vue so it can appear in the project view as well.

  • The creation of the download link is triggered when Document.vue is mounted so things are faster
  • Button won't be there if doi is absent
  • Button will have loading spinner icon and be disabled while a download link is being generated
Screen.Recording.2023-04-03.at.2.08.55.PM.mov

@shawnyama shawnyama marked this pull request as ready for review April 3, 2023 18:37
@shawnyama
Copy link
Contributor Author

Not sure why the first check failed

@shawnyama shawnyama merged commit 115c991 into main Apr 3, 2023
@shawnyama shawnyama deleted the move-pdf-download branch April 3, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants