Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: open pdf button uses generated link as fallback #950

Merged
merged 2 commits into from
Apr 3, 2023
Merged

feat: open pdf button uses generated link as fallback #950

merged 2 commits into from
Apr 3, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Apr 3, 2023 •
edited
Loading

Description

Open PDF button uses the generated link as a fallback

Screen.Recording.2023-04-03.at.4.07.12.PM.mov

@shawnyama shawnyama changed the title feat: open pdf in another window feat: open pdf button uses generated link as fallback Apr 3, 2023
@shawnyama shawnyama marked this pull request as ready for review April 3, 2023 20:07
YohannParis
YohannParis approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

@shawnyama shawnyama merged commit ef4eeff into main Apr 3, 2023
@shawnyama shawnyama deleted the open-pdf branch April 3, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnyama @YohannParis